Duckboot/cv4pve-cli-tui
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Warn on an untested cv4pve-cli version at startup #27

Merged
Duckboot merged 1 commits from feat/version-check-14 into main 2026-11-03 01:32:41 +01:00
Conversation 0 Commits 1 Files Changed 5
+83 -1
Duckboot commented 2026-11-03 00:30:30 +01:00
Owner
Copy link
Copy source

What

  • Version check: at startup the app runs cv4pve-cli --version. If the result differs from cli.TESTED_VERSION (2.4.0), a warning names the version found and the version tested.
  • Why: the app parses output formats that are not a stable API: the config list text, prune-backups as a JSON string, the CT ip-addresses JSON string, and the exit codes with --wait. A newer cv4pve-cli could break these in confusing ways.
  • Missing binary: if cv4pve-cli cannot be run at all, one error says so, instead of every later call failing without an explanation.
  • README: notes the tested version.

Verification

  • 446 tests pass.
  • ruff check and ruff format --check report no issues.
  • betterleaks found no secrets.
  • Live: cli.version() returns 2.4.0, so no warning is shown.

This is the first PR of the low-priority / nice-to-have stack. The stack is merged in order at the end.

Closes #14

Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com

## What - **Version check:** at startup the app runs `cv4pve-cli --version`. If the result differs from `cli.TESTED_VERSION` (2.4.0), a warning names the version found and the version tested. - **Why:** the app parses output formats that are not a stable API: the `config list` text, `prune-backups` as a JSON string, the CT `ip-addresses` JSON string, and the exit codes with `--wait`. A newer cv4pve-cli could break these in confusing ways. - **Missing binary:** if `cv4pve-cli` cannot be run at all, one error says so, instead of every later call failing without an explanation. - **README:** notes the tested version. ## Verification - 446 tests pass. - `ruff check` and `ruff format --check` report no issues. - `betterleaks` found no secrets. - Live: `cli.version()` returns `2.4.0`, so no warning is shown. This is the first PR of the low-priority / nice-to-have stack. The stack is merged in order at the end. Closes #14 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Duckboot added 1 commit 2026-11-03 00:30:30 +01:00
Warn on an untested cv4pve-cli version at startup
CI / pytest and ruff (pull_request) Successful in 4m42s
Details
CI / pytest and ruff (push) Has been cancelled
Details
e7569a7bf7 
At startup the app runs `cv4pve-cli --version`. If it differs from
cli.TESTED_VERSION (2.4.0), a warning says which version was found
and which one was tested. The app parses output formats that are not
a stable API: the config list text, prune-backups as a JSON string,
the CT ip-addresses JSON string and the exit codes with --wait. A
newer cv4pve-cli could break them in confusing ways.

If cv4pve-cli cannot be run at all, an error says so once, instead of
every later call failing without explanation. The README notes the
tested version.

Closes #14

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Duckboot merged commit e7569a7bf7 into main 2026-11-03 01:32:41 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
priority
1-high
Do first: biggest safety or maintenance gain
priority
2-medium
Next: clear everyday value
priority
3-low
Useful, but less often needed
priority
4-nice-to-have
Small conveniences; do when convenient
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Duckboot (Per-Arne Hellarvik)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Duckboot/cv4pve-cli-tui#27