Duckboot/cv4pve-cli-tui
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Flag guests that no backup job covers #20

Merged
Duckboot merged 1 commits from feat/not-backed-up-9 into main 2026-11-02 23:28:07 +01:00
Conversation 0 Commits 1 Files Changed 5
+97 -6
Duckboot commented 2026-11-02 23:27:56 +01:00
Owner
Copy link
Copy source

What

  • The guest table marks with ! each guest that no backup job covers.
  • The frame's bottom border shows the count, for example "mainframe · 2 without backup job".
  • The data comes from Proxmox's own list (get cluster not-backed-up). It therefore also counts jobs that select guests by pool, which the app's own job matching does not handle.
  • If the coverage call fails, the guests are still listed and a warning says the coverage is unknown.

Verification

  • 277 tests pass on this branch (cv4pve-cli is mocked).
  • ruff check and ruff format --check report no issues.
  • betterleaks found no secrets.
  • Read-only live check on mainframe: not-backed-up returned an empty list, so no marks and no count were shown. Every guest there is covered, so a real positive has not been seen live.

Closes #9

Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com

## What - The guest table marks with `!` each guest that no backup job covers. - The frame's bottom border shows the count, for example "mainframe · 2 without backup job". - The data comes from Proxmox's own list (`get cluster not-backed-up`). It therefore also counts jobs that select guests by pool, which the app's own job matching does not handle. - If the coverage call fails, the guests are still listed and a warning says the coverage is unknown. ## Verification - 277 tests pass on this branch (`cv4pve-cli` is mocked). - `ruff check` and `ruff format --check` report no issues. - `betterleaks` found no secrets. - Read-only live check on mainframe: `not-backed-up` returned an empty list, so no marks and no count were shown. Every guest there is covered, so a real positive has not been seen live. Closes #9 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Duckboot added 1 commit 2026-11-02 23:27:56 +01:00
Flag guests that no backup job covers 520de16cc6 
The guest table marks with "!" each guest that Proxmox's not-backed-up
list returns. The frame's bottom border shows the count, e.g.
"mainframe · 2 without backup job". This uses Proxmox's own answer, so
it also counts jobs that select guests by pool.

If the coverage call fails, the guests are still listed and a warning
says the coverage is unknown.

Closes #9

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Duckboot merged commit 520de16cc6 into main 2026-11-02 23:28:07 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
priority
1-high
Do first: biggest safety or maintenance gain
priority
2-medium
Next: clear everyday value
priority
3-low
Useful, but less often needed
priority
4-nice-to-have
Small conveniences; do when convenient
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Duckboot (Per-Arne Hellarvik)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Duckboot/cv4pve-cli-tui#20