Duckboot/cv4pve-cli-tui
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Edit autostart, startup order and tags #30

Merged
Duckboot merged 1 commits from feat/boot-options-18 into main 2026-11-03 01:33:14 +01:00
Conversation 0 Commits 1 Files Changed 6
+634
Duckboot commented 2026-11-03 00:55:11 +01:00
Owner
Copy link
Copy source

What

  • Info screen: the Resources table now shows Autostart (yes/no), Startup (order, plus up and down delays) and Tags.
  • Editing: o opens a dialog to change these. Only keys that differ are sent, in one set <kind> config call through the existing set_net. A confirm lists the old and new value of each key.
  • Removing tags: done with --delete tags on set config. cv4pve-cli also has a delete ct|vm ... tags command, but it shares the form that destroys the whole guest, so the app never uses it. No code path builds a delete ct|vm argv; the review confirmed this with grep.
  • Validation:
    • startup values must be integers ≥ 0
    • tags must match [A-Za-z0-9_][A-Za-z0-9_+.-]*
    • tags are split on ;, , or whitespace, and duplicates are removed

Verification

  • 569 tests pass, including hypothesis properties:
    • tags_value is idempotent
    • parse_startup reverses startup_value
  • ruff check and ruff format --check report no issues.
  • betterleaks found no secrets.
  • Live test on CT 104, through the dialog: onboot 1 → 0, startup order=5,up=10, and tag tui-test added. Then all three were set back the same way, and the config ended identical to the baseline.

This PR is stacked on #29 → #28 → #27.

Closes #18

Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com

## What - **Info screen:** the Resources table now shows Autostart (yes/no), Startup (order, plus up and down delays) and Tags. - **Editing:** `o` opens a dialog to change these. Only keys that differ are sent, in one `set <kind> config` call through the existing `set_net`. A confirm lists the old and new value of each key. - **Removing tags:** done with `--delete tags` on `set config`. cv4pve-cli also has a `delete ct|vm ... tags` command, but it shares the form that destroys the whole guest, so the app never uses it. No code path builds a `delete ct|vm` argv; the review confirmed this with grep. - **Validation:** - startup values must be integers ≥ 0 - tags must match `[A-Za-z0-9_][A-Za-z0-9_+.-]*` - tags are split on `;`, `,` or whitespace, and duplicates are removed ## Verification - 569 tests pass, including hypothesis properties: - `tags_value` is idempotent - `parse_startup` reverses `startup_value` - `ruff check` and `ruff format --check` report no issues. - `betterleaks` found no secrets. - Live test on CT 104, through the dialog: onboot 1 → 0, startup `order=5,up=10`, and tag `tui-test` added. Then all three were set back the same way, and the config ended identical to the baseline. This PR is stacked on #29 → #28 → #27. Closes #18 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Duckboot added 4 commits 2026-11-03 00:55:11 +01:00
Warn on an untested cv4pve-cli version at startup
CI / pytest and ruff (pull_request) Successful in 4m42s
Details
CI / pytest and ruff (push) Has been cancelled
Details
e7569a7bf7 
At startup the app runs `cv4pve-cli --version`. If it differs from
cli.TESTED_VERSION (2.4.0), a warning says which version was found
and which one was tested. The app parses output formats that are not
a stable API: the config list text, prune-backups as a JSON string,
the CT ip-addresses JSON string and the exit codes with --wait. A
newer cv4pve-cli could break them in confusing ways.

If cv4pve-cli cannot be run at all, an error says so once, instead of
every later call failing without explanation. The README notes the
tested version.

Closes #14

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Document installing cv4pve-tui as a uv tool
CI / pytest and ruff (pull_request) Successful in 4m40s
Details
CI / pytest and ruff (push) Has been cancelled
Details
ff6345c80f 
The README gets an "Install" section: install with uv tool from the
Gitea repo or from a local checkout, then upgrade and uninstall. The
"Run" section says to use `cv4pve-tui` when installed and
`uv run cv4pve-tui` from a checkout.

Verified by installing into throwaway tool dirs (UV_TOOL_DIR and
UV_TOOL_BIN_DIR under /tmp): `uv tool install .` gave a cv4pve-tui
binary. Started from /tmp in a pseudo-terminal, it drew the guest
frame and ran until it was stopped. The pyproject metadata (entry
point, readme, requires-python) was already enough.

Closes #17

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add search and filter to the guest table
CI / pytest and ruff (pull_request) Successful in 4m48s
Details
CI / pytest and ruff (push) Has been cancelled
Details
d97ad22c78 
/ opens a filter box under the guest table, and the table filters as
you type. Terms are separated by spaces, all must match, and case is
ignored:

- a plain term matches part of the name, the VMID or a tag
- is:running and is:stopped match the status
- type:lxc/ct and type:vm/qemu match the guest type

Enter keeps the filter and goes back to the table. Escape clears it,
from the box or from the table. The frame shows
"· filter: <text> · N of M". Actions only ever see the visible rows,
and the filter survives reloads and context switches.

Review fixes:
- Typing "[/b]" or "[/]" crashed the app, because the filter text went
  into the border subtitle, which Textual parses as markup. The
  subtitle is now plain text, so "[red]" is also shown literally.
- Escape on the table now clears a filter that was applied with Enter.
- guest_matches tolerates a None status or type.

Read-only live check on mainframe: "debian" gives 104, "type:vm" gives
108, "community-script is:running" gives 14 of 19, and "is:stopped"
gives 0 of 19.

Closes #16

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Edit autostart, startup order and tags from the info screen
CI / pytest and ruff (pull_request) Successful in 5m31s
Details
CI / pytest and ruff (push) Has been cancelled
Details
f5f3effce5 
The info screen's Resources table shows Autostart (yes/no), Startup
(order, up and down delays) and Tags. o opens a dialog to change them.
Only keys that differ are sent, in one `set <kind> config` call
through the existing set_net. A confirm lists the old and new value
of each key.

Tags are removed with `--delete tags` on set config. The CLI also has
a `delete ct|vm ... tags` command, but it shares the form that
destroys the whole guest, so the app never uses it; nothing in the
code builds a delete ct|vm argv. Inputs are validated before sending:
startup values must be ints >= 0, and tags must match
[A-Za-z0-9_][A-Za-z0-9_+.-]*. They are split on ; , or whitespace and
deduplicated.

Live test on CT 104: onboot 1 -> 0, startup order=5,up=10, tag
tui-test added, then all set back through the dialog. The config
ended identical to the baseline.

Closes #18

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Duckboot merged commit f5f3effce5 into main 2026-11-03 01:33:14 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
priority
1-high
Do first: biggest safety or maintenance gain
priority
2-medium
Next: clear everyday value
priority
3-low
Useful, but less often needed
priority
4-nice-to-have
Small conveniences; do when convenient
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Duckboot (Per-Arne Hellarvik)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Duckboot/cv4pve-cli-tui#30